Conversation
NourhaneBoudaoud
added
the
Good first issue
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you for your pull request @Hypertopic/tutos.
To improve other scenarios to come, please read commented lines.
Please note also that commit titles should be very strictly named (check Moodle for the rules to apply).
For this particular enhancement, there is a far simpler way to think about this improvement: see what I wrote on the issue discussion (#365). You will see that the scenario (and tests and implementation) will be far easier to update.
You only have to change one line in this scenario.
|
|
||
|
|
||
|
|
||
| Scénario: via le bouton d'insertion de l'interface |
There was a problem hiding this comment.
Please don't mention user interface details in scenarios.
|
|
||
| Soit un document dont je suis l'auteur affiché comme glose | ||
| Et une session active avec mon compte | ||
| Quand je clique sur l'icône "Add a video" |
There was a problem hiding this comment.
Please don't mention user interface details in scenarios.
| Soit un document dont je suis l'auteur affiché comme glose | ||
| Et une session active avec mon compte | ||
| Quand je clique sur l'icône "Add a video" | ||
| Et que je saisis le lien "https://www.youtube.com/watch?v=JRXkAhMYKEc&ab_channel=ViniciusHenrique" dans la boîte de dialogue |
There was a problem hiding this comment.
When (Quand) must be a single step. It corresponds to the feature. Therefore it should be named in a way very similar to the feature name.
| Et une session active avec mon compte | ||
| Quand je clique sur l'icône "Add a video" | ||
| Et que je saisis le lien "https://www.youtube.com/watch?v=JRXkAhMYKEc&ab_channel=ViniciusHenrique" dans la boîte de dialogue | ||
| Et que je valide l'insertion |
There was a problem hiding this comment.
When (Quand) must be a single step. It corresponds to the feature. Therefore it should be named in a way very similar to the feature name.
| Et que je saisis le lien "https://www.youtube.com/watch?v=JRXkAhMYKEc&ab_channel=ViniciusHenrique" dans la boîte de dialogue | ||
| Et que je valide l'insertion | ||
| Alors le document comporte la vidéo "https://www.youtube.com/embed/JRXkAhMYKEc" | ||
| Et le texte brut de la glose contient "" |
3 participants
We, [FILL WITH FULL NAMES], hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.