Fix application status in confirmation email context (4678)#4679
Closed
bmispelon wants to merge 1 commit intoHyphaApp:mainfrom
Closed
Fix application status in confirmation email context (4678)#4679bmispelon wants to merge 1 commit intoHyphaApp:mainfrom
bmispelon wants to merge 1 commit intoHyphaApp:mainfrom
Conversation
bmispelon
force-pushed
the
issue-4678-confirmation-email-status-draft
branch
from
d5d76de to
64a4435
Compare
| code=SUBMISSION_DRAFT, user=by, related_obj=instance | ||
| ) | ||
| # notify for a new submission | ||
| instance.status = target |
Member
There was a problem hiding this comment.
I am not sure, but it might cause issues at another place because it is mentioned in Line 1042-43 that "instance status here would be the old phase and we have to pass new phase as an arg" like it is done in Line 1070 . You may need to look for edge cases if it is not causing any other issue then it is fine otherwise i would suggest to use similar approach as we used below in MESSAGES.TRANSITION at line 1070.
Member
|
@bmispelon Can you test and see if #4693 solves this issue as well? I believe it should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4678