Potential fix for code scanning alert no. 4: Workflow does not contain permissions#258
Open
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#258
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IABTechLab/trusted-server/security/code-scanning/4
In general, the fix is to explicitly declare a
permissionsblock limiting the defaultGITHUB_TOKENpermissions to the least privilege needed. For this workflow, both jobs simply check out code and run tests; they do not need to write to repository contents, issues, or pull requests. The recommended minimal safe setting ispermissions: contents: readat the workflow level so it applies to all jobs, unless a specific job needs more.The best fix here is to add a top-level
permissionsblock right after thename(or beforejobs) in.github/workflows/test.yml, settingcontents: read. This documents the intended use and ensures bothtest-rustandtest-typescriptinherit read-only repo access. No other functionality needs to change, and no imports or extra methods are required because this is purely a YAML configuration change for GitHub Actions.Concretely:
.github/workflows/test.yml.between line 2 and line 3 (after
name: "Run Tests"and the blank line), keeping indentation consistent.Suggested fixes powered by Copilot Autofix. Review carefully before merging.