Draft
Conversation
caroline-ttd
reviewed
Jun 6, 2024
| req, nonce = make_v2_request(self._client_secret, dt.datetime.now(tz=timezone.utc), | ||
| json.dumps(request_payload).encode()) | ||
| resp = post(self._base_url, '/v2/optout/status', headers=auth_headers(self._api_key), data=req) | ||
| return parse_v2_response(self._client_secret, resp.read(), nonce) |
Contributor
There was a problem hiding this comment.
if we decide to merge it, would you mind have some unit tests for this class?
Contributor
There was a problem hiding this comment.
NVM, we do not want to spend too much time on this. And it is a simple class. No unit tests is also good to me.
caroline-ttd
reviewed
Jun 6, 2024
|
|
||
| def _usage(): | ||
| print( | ||
| 'Usage: python3 sample_optout_status_client.py <base_url> <api_key> <client_secret> <advertising_id_1> <advertising_id_2> ... <advertising_id_3>' |
Contributor
There was a problem hiding this comment.
nitpick: maybe <advertising_id_n> instead of <advertising_id_3>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.