Update "request" version to avoid security vulnerability#46
Open
kyle-apex wants to merge 1 commit intoIBM-Cloud:masterfrom
Open
Update "request" version to avoid security vulnerability#46kyle-apex wants to merge 1 commit intoIBM-Cloud:masterfrom
kyle-apex wants to merge 1 commit intoIBM-Cloud:masterfrom
Conversation
…ough-cookie version: tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
jungleBadger
approved these changes
Mar 9, 2018
srl295
approved these changes
Oct 1, 2018
|
ws also needs an update https://nodesecurity.io/advisories/550 |
|
Folks I'm asking to re-ignite this issue as the vulnerabilities introduced by this dependency are piling up... see https://snyk.io/test/npm/cf-client Disclaimer 1 - I work for @snyksec Can I suggest a naive change that will allow the client to track updates in its dependencies like so: This will remove 9 out of the 10 vulnerabilities that currently exist in this package via its dependencies. I acknowledge the fact this package is seeing very little traction over the past 2 years, but really hope that security considerations will be sufficient to make one more release 🙏 |
|
Good. Let's reboot this.
|
|
Ready with #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update "request" version to avoid dependency on vulnerable tough-cookie version:
npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130