Skip to content

Comments

Create powerai-based dockerfile, powerai builds for x86/ppc#22

Open
mattborgard wants to merge 4 commits intoIBM:masterfrom
mattborgard:master
Open

Create powerai-based dockerfile, powerai builds for x86/ppc#22
mattborgard wants to merge 4 commits intoIBM:masterfrom
mattborgard:master

Conversation

@mattborgard
Copy link
Member

No description provided.

@xuhdev
Copy link
Contributor

xuhdev commented Sep 5, 2019

The PR on its own LGTM, but I'm wondering whether there is a way to extract a large portion of travis.yml into an independent repository so that we do not have to do the same for all repos, especially when we want to do modification. I haven't come up with a way yet, as it seems like travis CI does not support a command that includes another yaml file as part of it. @bdwyer2 Do you have any good suggestions?

@mattborgard
Copy link
Member Author

Some sort of "master template" in a repo, with just the image name replaced by some sort of script, makes a certain amount of sense. But as you said, I'm not sure Travis supports anything like that, so it might be a bit of a hack to get it to work. We'd need a CI build to modify the travis.yaml and then a separate CI job to actually build the images.

We could likely include some of the individual steps as bash scripts in some other repo that we pull, text replace and execute. I don't know if that saves us a ton of work, but it's something to consider. Let me know what y'all want to do.

@xuhdev
Copy link
Contributor

xuhdev commented Sep 5, 2019

I personally think it might be better to move some scripts into an individual repo and include it as a submodule, and we call them from .travis.yml. What do you think? Perhaps we have to discuss with other team members about this restructure as well. @bdwyer2 @ajbozarth @MLnick

@xuhdev
Copy link
Contributor

xuhdev commented Sep 9, 2019

I'll bring this up in scrum tomorrow.

@xuhdev
Copy link
Contributor

xuhdev commented Sep 10, 2019

We decide to open a new repo under CODAIT as a submodule so that we can move some of the frequently reused parts to that repo. Will notify you soon once it is created.

@xuhdev
Copy link
Contributor

xuhdev commented Sep 10, 2019

The new repo is here: https://github.com/CODAIT/MAX-commons/

Feel free to move some of the scripts that you think will be frequently used to that repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants