fix: hex support on 2025.1#1730
Merged
sergej-koscejev merged 5 commits intomaintenance/mps20251from Apr 13, 2026
Merged
Conversation
The new version contains editor test lifecycle annotations.
Add a language, org.iets3.internal.modelaccessor, containing a NodeAttribute to override the model accessor of an EditorCell_Property or SplittableCell. To be used instead of setting a final field with reflection.
Change hex-capable editors to use the new modelaccessor language instead of reflection. Fixes #1715
sergej-koscejev
force-pushed
the
bugfix/hexadecimal
branch
from
c8abc2c to
fd4d2a8
Compare
Member
|
Looking into it now. |
Member
|
Do you think it makes sense to move the new language to the ‘mps-extensions’ ? |
arimer
approved these changes
Apr 13, 2026
Member
arimer
left a comment
arimer
left a comment
There was a problem hiding this comment.
Changes look good. Thanks for adding the additional editor tests and cleaning up the build 👍🏼
Member
Author
I thought about this but decided against it because overriding property accessors is only necessary for the current design of IETS3 hex literals and doesn't feel like an approach that we should encourage other projects to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1715.
Introduce a new language for replacing model accessors in property cells.
Also a few minor build tweaks.