Specify a color and intensity for the directional light#49
Open
vincentmarchetti wants to merge 1 commit intoIIIF:mainfrom
Open
Specify a color and intensity for the directional light#49vincentmarchetti wants to merge 1 commit intoIIIF:mainfrom
vincentmarchetti wants to merge 1 commit intoIIIF:mainfrom
Conversation
color and intensity match the color and intensity of the draft ambient light, to allow comparison of the two lighting effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3d:main 3_lights/direction_light_transform_rotate.json manifest did not have a color or intensity specified for the light. Since default values are not given in the draft api, a color and intensity are added to the manifest in this PR
color and intensity match the color and intensity of the draft ambient light, to allow comparison of the two lighting effects