-
Notifications
You must be signed in to change notification settings - Fork 398
[Fix] #0046465 UI: Remove TOP Button form Standard Form #10812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_11
Are you sure you want to change the base?
Conversation
3c29f5a to
f8423bc
Compare
oliversamoila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello everyone.
For this PR, it is worth reading Fabian Kruse's summary of the discussions with @yvseiler. However, the Mantis issues marked as related also address the problem regularly, and certainly not all related and frequently reported tickets are marked here.
From a UX and UI perspective, the result looks really good. Thank you very much for your contribution, @fhelfer and Fabian Kruse.
I would recommend that @thibsy continue with the code review. Once this is done, I believe the changes could be integrated into Release 11 and Trunk. I would like to communicate the changes to the JourFixe – then we can decide whether or not the changes should still be integrated into Release 10.
Why should a careful decision be made for Release 10? There are already various forms that use the UI framework. In these cases, the upper Submit button would be missing by default and would have to be re-integrated deliberately. Very long forms are likely to be among such cases. These could be forms used to configure object settings, for example.
Below are two examples where the changes can be seen.
- Login screen
- Creation of test questions
Kind regards,
@oliversamoila (as UI coordinator)
Login form with top submit button:
Login form without top submit button
Creation of test questions form with top submit button
Creation of test questions form without top submit button:
|
Hi @fhelfer and @oliversamoila Thank you very much for this improvement! If I'm understanding this right, this is actually the right move from an accessibility point of view and I agree with Fabian that also from a usability perspective this is better. I would kindly ask you though to reconsider adding the Why:
Thanks again and best, |
|
Sometimes it's the little things that make you feel all fidgety with anticipation. Thanks a lot for moving this forward, @oliversamoila & @fhelfer! One question concerning the previews: They still show a duplicate "Required *" marker on the top. It was my (probably wrong) understanding, that there would also vanish if we got rid of the buttons. Wouldn’t that still make sense? Cheers |
|
Dear @kergomard, I don't want to address the question of whether or not some of these forms should be shortened in this improvement. We want to make progress – so it doesn't help to make the problem even bigger. For me, it's also fine if we always have only one action to submit the information at the end of a form, once I've moved through it. Kind regards, |
|
Dear @fab-kru, Kind regards, |
|
After having had a quick chat with @dsstrassner , I think I can greenlight the removal of the upper buttons for the Test and the User, so we would already be good for the current uses. Best, |
|
Many thanks to everyone involved. @thibsy and I had another discussion following the feedback and recommend generally removing the top button. Best regards, |
f8423bc to
59b69ec
Compare
|
Jour Fixe, 09 FEB 2026: We had a longer discussion about screens with long forms where a top button would be helpful and make the page more usable. Nevertheless, we decide to accept this PR and remove top buttons from KS forms also because of accessibility (one submit button is better then two). We should keep on discussing how to proceed with these specific cases where long forms then would require scrolling down. One option could be a floating button - if accessible. Another could be an exception to this new behaviour and allow developers to add a top button in selected cases. |
59b69ec to
e49b2bd
Compare
|
Hey @thibsy, @oliversamoila how would we like to proceed with top actions? After rabasing the commits i noticed that top-actions (Buttons) got introduced to the top-section of the form. |




https://mantis.ilias.de/view.php?id=46465
As suggested, there is no valid use-case where the TOP-Button of Standard Buttons has a reason to exist.
Therefore, this PR suggests removing it by default, but creating a method that allows to enable it if necessary