[LSO][FIX] Learning Sequence import from older ILIAS versions without position attribute #11086
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XSD Schema Update: Changed the position attribute of the LSItem element from required to optional in ilias_lso_9_0.xsd. This ensures that XML files from older versions pass the schema validation.
• Robust XML Parsing: Updated ilLearningSequenceXMLParser to check for the existence of the position attribute before attempting to store it in the internal data array.
• Safe Importing: Modified ilLearningSequenceImporter to only apply the item order number if the position data is actually available in the imported set. If missing, the default sorting of the system is used.