Skip to content

Conversation

@mBeym
Copy link
Contributor

@mBeym mBeym commented Feb 10, 2026

Fixes https://mantis.ilias.de/view.php?id=47191

If accepted should be picked into trunk

@mjansenDatabay mjansenDatabay added bugfix php Pull requests that update Php code labels Feb 10, 2026
@kergomard
Copy link
Contributor

Thank you very much for the PR @mBeym .

I do not think though, that this fully solves the problem. You are comparing the values as arrays, which in turn would lead to small differences in values that are not displayed (i.e. 'value' and 'searchBy') leaving the corresponding entries in and being still shown to the user as duplicates.

What if we would move the array_map to an array_reduce and use $v->getTagArray()['display'] as keys? This would lead to the value from the profile_data_repository being used, as this value will be the last one. To be on the save side we could then wrap everything in an array_values (please set this to its own line). We do not care about sorting, as we are doing this in the next step.

Best,
@kergomard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants