[FIX] #46588 UI: Input\Container\Filter\FilterInput JavaScript binding
#11103
+190
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes https://mantis.ilias.de/view.php?id=46588 * Update HTML of filter input context * Update rendering unit tests * Add new filter example
thibsy
added
bugfix
kitchen sink
php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
During the review of #10780 I have tried to find the root cause of this issue. What @schmitz-ilias proposed was merely a bandaid for the fact that filter inputs were left behind in some refactoring of the form context and its JavaScript binding. I therefore streamlined this so the necessary HTML attributes for the JavaScript binding to work are now registered similar as to the form inputs.
In addition, I had to rewrite the "update-on-load-code" of the duration and multi-select fields, because jQuery had some odd behaviour regarding its event-listening of elements, which I now replaced with vanilla JS.
@oliversamoila I kindly ask you to verify this behaviour on a test installation.
Kind regards,
@thibsy (as UI coordinator)