Skip to content

[FIX] #47457 MediaObject: add maphilight as npm Dependency for ILIAS 10 #11325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibsy wants to merge 1 commit into
base: release_10
Choose a base branch
from
Open

[FIX] #47457 MediaObject: add maphilight as npm Dependency for ILIAS 10 #11325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ILIAS/COPage/js/ilCOPagePres.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ il.COPagePres = {

// init map areas
initMapAreas() {
// $('img[usemap^="#map_il_"][class!="ilIim"]').maphilight({ neverOn: true });
$('img[usemap^="#map_il_"][class!="ilIim"]').maphilight({ neverOn: true });
},

/// /
Expand Down
2 changes: 2 additions & 0 deletions components/ILIAS/MediaObjects/MediaObject/class.ilObjMediaObjectGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,6 +1467,8 @@ public static function includePresentationJS(

iljQueryUtil::initjQuery($a_tpl);
$a_tpl->addJavaScript("components/ILIAS/COPage/js/ilCOPagePres.js");
$a_tpl->addJavaScript("assets/js/jquery.maphilight.min.js");


//ilPlayerUtil::initMediaElementJs($a_tpl);
}
Expand Down
2 changes: 0 additions & 2 deletions components/ILIAS/jQuery/jQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ public function init(
$contribute[Component\Resource\PublicAsset::class] = fn() =>
new Component\Resource\NodeModule("jquery-ui-dist/jquery-ui.js");
*/
/* This library was missing after discussing dependencies for ILIAS 10
$contribute[Component\Resource\PublicAsset::class] = fn() =>
new Component\Resource\NodeModule("maphilight/jquery.maphilight.min.js");
*/
}
}
30 changes: 24 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"jstree": "^3.3.16",
"linkify-element": "^4.3.2",
"linkifyjs": "^4.3.2",
"maphilight": "^1.5.0",
"moment": "^2.29.4",
"tinymce": "^7.3.0",
"webui-popover": "^1.2.18"
Expand Down
Loading