Skip to content

Container/Export: patch to remove faulty multilingalism entries after container import #11330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chlulei wants to merge 2 commits into
base: release_11
Choose a base branch
from
+31 −1
Open

Container/Export: patch to remove faulty multilingalism entries after container import #11330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e093e14
Container/Export: patch to remove faulty multilingalism entries after…
chlulei Mar 25, 2026
e163402
Container/Export: patch to remove faulty multilingalism entries afte…
chlulei Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions components/ILIAS/Container/Export/class.ilContainerImporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
*
*********************************************************************/

use ILIAS\ILIASObject\Properties\Translations\CachedRepository as TranslationsRepository;
use ILIAS\ILIASObject\Properties\Translations\Translations as Translations;

/**
* container xml importer
*
Expand All @@ -27,10 +30,16 @@ class ilContainerImporter extends ilXmlImporter
protected ilLogger $cont_log;
protected \ILIAS\Skill\Service\SkillProfileService $skill_profile_service;

# Patch Start: Fix multilingualism replaces course title
protected string $import_id;
protected TranslationsRepository $translations_repository;
# Patch End: Fix multilingualism replaces course title

public function init(): void
{
global $DIC;

$this->translations_repository = new TranslationsRepository($DIC->database());
$this->cont_log = ilLoggerFactory::getLogger('cont');
$this->skill_profile_service = $DIC->skills()->profile();
}
Expand All @@ -48,6 +57,10 @@ public function importXmlRepresentation(string $a_entity, string $a_id, string $

$parser = new ilContainerXmlParser($a_mapping, trim($a_xml));
$parser->parse($a_id);

# Patch Start: Fix multilingualism replaces course title
$this->import_id = $a_id;
# Patch End: Fix multilingualism replaces course title
}

/**
Expand Down Expand Up @@ -96,6 +109,19 @@ public function finalProcessing(ilImportMapping $a_mapping): void
ilParticipants::getDefaultMemberRole((int) $new_crs_ref_id)
);
}

# Patch Start: Fix multilingualism replaces course title
$obj_id = (int) $a_mapping->getMapping('components/ILIAS/ILIASObject', 'obj', $this->import_id);
$translations = $this->translations_repository->getFor($obj_id);
$translations_new = new Translations($translations->getObjId(), [], $translations->getDefaultLanguage(), $translations->getBaseLanguage());
$languages = $translations->getLanguages();
foreach ($languages as $language) {
$translations_new = $language->getTitle() === 'NO TITLE'
? $translations_new
: $translations_new->withLanguage($language);
}
$this->translations_repository->store($translations_new);
# Patch End: Fix multilingualism replaces course title
}

protected function handleOfflineStatus(string $xml, ilImportMapping $mapping): void
Expand Down
6 changes: 5 additions & 1 deletion components/ILIAS/Export/classes/class.ilImportContainer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ protected function createDummy(string $a_type): ilObject
$class_name = "ilObj" . $this->objDefinition->getClassName($a_type);

$new = new $class_name();
$new->setTitle('Import');

# Patch Start: Fix multilingualism replaces course title
$new->setTitle('NO TITLE');
# Patch End: Fix multilingualism replaces course title

$new->create(true);
$new->createReference();
$new->putInTree($this->getMapping()->getTargetId());
Expand Down
Loading