[Fix] Init: ErrorPageResponder with missing DIC dependecies#11363
Open
fhelfer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Open
[Fix] Init: ErrorPageResponder with missing DIC dependecies#11363fhelfer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
fhelfer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Conversation
fhelfer
added
bugfix
php
mjansenDatabay
requested changes
Mar 30, 2026
Comment on lines
+113
to
+114
| $local_tpl->setVariable('LINK_HREF', ''); | ||
| $local_tpl->setVariable('LINK_TEXT', ''); |
Contributor
There was a problem hiding this comment.
We should not render an a element with empty attributes/innerHTML in this case. IMO we should not render this element at all here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.