[FEATURE] Data,Refinery: add QR code support#11391
Open
thibsy wants to merge 2 commits intoILIAS-eLearning:trunkfrom
Open
[FEATURE] Data,Refinery: add QR code support#11391thibsy wants to merge 2 commits intoILIAS-eLearning:trunkfrom
thibsy wants to merge 2 commits intoILIAS-eLearning:trunkfrom
Conversation
613b2fe to
3de0fa2
Compare
* Add `ILIAS\Data\QR\SVGCode` wrapper for generated QR codes. * Add `ILIAS\Data\QR\ErrorCorrectionLevel` for standardised error correction levels. * Add `ILIAS\Refinery\String\QRCode` transformation to convert string into a QR code. * Add unit tests covering the functionality above.
3de0fa2 to
0e88c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mjansenDatabay,
This is the first iteration of my QR code abstraction for ILIAS, which I plan on using inside the UI framework to convert
ILIAS\Data\URIobjects into a QR code which can be embedded inline as a data URI.I haven't worked out the exact details of the UI interface yet, so there may be changes in the meantime, but I'd still like to hear your 5 cents about this – it doesn't need to be an in-depth code review just yet. I will also wait with the JF label until you have approved of the details, although I will post the formal request in here some time soon already.
What I have worked out:
What I haven't worked out (yet):
Looking forward to your thoughts.
Thx and kind regards,
@thibsy