TA 47194: Fixes long menu question point correction modal closing issue#11394
Open
thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
Open
TA 47194: Fixes long menu question point correction modal closing issue#11394thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
Conversation
…ng rendered modals outside of form scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR is related to Mantis ticket https://mantis.ilias.de/view.php?id=47194.
The issue described in this ticket occurs because rendering the KS modals creates nested forms. Since browsers treat this as invalid HTML, they manipulate the faulty markup and remove all inner form tags. This leads to the behavior described in the ticket.
To solve the problem, it must be ensured that the forms (modals) are rendered outside the actual form context. Unfortunately, we could not find any other way than to adapt the central form component.
@kergomard : If you have a better suggestion here, we would be grateful for your input. We evaluated various scenarios, but this was the “best” solution we could find.
I addition, i didn't find anyone, who is responsible for components/Form. So maybe @dsstrassner could add other authorities, if required.
Best Regards,
@thojou