Allow customization of MAG L2 frames#2881
Open
alastairtree wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
Open
Allow customization of MAG L2 frames#2881alastairtree wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
alastairtree wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
- in mag_l2 function and update tests accordingly - used (externally) by MAG team to generate l2 files without needing all files
Contributor
Author
|
Paging @maxinelasp - please could you take a look at this, a small change to MAG L2 to enable us to generate frames programmatically without having to generate all of them. We (intend) to call this code in our internal pipeline over at https://github.com/ImperialCollegeLondon/imap-pipeline-core/blob/feat/set-quality-and-nan/src/mag_toolkit/calibration/CalibrationApplicator.py#L207 |
maxinelasp
approved these changes
Mar 30, 2026
Contributor
Author
|
Thanks @maxinelasp. What is the cadence of your releases & when can i expect to see this change on pypy? No pressure, just want to know what to expect. |
Contributor
|
@alastairtree We usually do a few a month - if you would like this out ASAP, I can cut a release this week |
Contributor
Author
|
Next routine release is fine thanks. I cant merge it so over to you to release it please and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Adds option to customise which frames are generated when calling mag l2 programatically. Used (externally) by MAG team to generate l2 files without needing all CDF files
Testing
I have updated the unite tests to cover this new use case.
The main API has not actually changed as this is just a new param with defaults that match the existing behaviou so should have zero consequences other than making it more flexible