Skip to content

IDEX l1b filter for desired evt messages#2882

Merged
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
lacoak21:idex_l1b_msg_filter_ds_for_events
Mar 30, 2026
Merged

IDEX l1b filter for desired evt messages#2882
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
lacoak21:idex_l1b_msg_filter_ds_for_events

Conversation

@lacoak21
Copy link
Copy Markdown
Contributor

Change Summary

Overview

Filter the l1b event message dataset to only include messages that are for pulser on / off and science on/off

File changes

imap_processing/idex/idex_l1b.py

  • Remove inds where both science on and pulser on are null

Testing

Update test

@lacoak21 lacoak21 added this to the March 2026 milestone Mar 30, 2026
@lacoak21 lacoak21 requested a review from Copilot March 30, 2026 15:38
@lacoak21 lacoak21 self-assigned this Mar 30, 2026
@lacoak21 lacoak21 added this to IMAP Mar 30, 2026
@lacoak21 lacoak21 marked this pull request as ready for review March 30, 2026 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates IDEX L1B “msg” processing to drop event-message rows that don’t correspond to science acquisition on/off or pulser on/off, and adjusts the associated unit test expectations to reflect the filtered dataset.

Changes:

  • Filter the L1B MSG dataset to exclude rows where both pulser_on and science_on are the 255 fill value.
  • Update test_l1b_msg_processing expected indices to match the new filtered ordering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
imap_processing/idex/idex_l1b.py Filters MSG output dataset to keep only science/pulser on/off-related rows.
imap_processing/tests/idex/test_idex_l1b.py Updates MSG processing test expectations for shifted indices after filtering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lacoak21 lacoak21 merged commit 5468771 into IMAP-Science-Operations-Center:dev Mar 30, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this to Done in IMAP Mar 30, 2026
@lacoak21 lacoak21 deleted the idex_l1b_msg_filter_ds_for_events branch March 30, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants