IDEX l1b filter for desired evt messages#2882
Merged
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom Mar 30, 2026
Merged
IDEX l1b filter for desired evt messages#2882lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates IDEX L1B “msg” processing to drop event-message rows that don’t correspond to science acquisition on/off or pulser on/off, and adjusts the associated unit test expectations to reflect the filtered dataset.
Changes:
- Filter the L1B MSG dataset to exclude rows where both
pulser_onandscience_onare the 255 fill value. - Update
test_l1b_msg_processingexpected indices to match the new filtered ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
imap_processing/idex/idex_l1b.py |
Filters MSG output dataset to keep only science/pulser on/off-related rows. |
imap_processing/tests/idex/test_idex_l1b.py |
Updates MSG processing test expectations for shifted indices after filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tech3371
approved these changes
Mar 30, 2026
5468771
into
IMAP-Science-Operations-Center:dev
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Filter the l1b event message dataset to only include messages that are for pulser on / off and science on/off
File changes
imap_processing/idex/idex_l1b.py
Testing
Update test