Skip to content

GLOWS Ancillary file rename#2887

Merged
maxinelasp merged 2 commits intoIMAP-Science-Operations-Center:devfrom
maxinelasp:glows-2878-anc-file-rename
Mar 30, 2026
Merged

GLOWS Ancillary file rename#2887
maxinelasp merged 2 commits intoIMAP-Science-Operations-Center:devfrom
maxinelasp:glows-2878-anc-file-rename

Conversation

@maxinelasp
Copy link
Copy Markdown
Contributor

Change Summary

Address the changes in #2878 to rename ancillary files used.

This also passes the calibration file through to L2 processing to make #2886 easier.

As a note: this will not run in production without the matching changes in sds-data-manager (PR up now.)

@maxinelasp maxinelasp added this to the March 2026 milestone Mar 30, 2026
@maxinelasp maxinelasp self-assigned this Mar 30, 2026
@maxinelasp maxinelasp added the Ins: GLOWS Related to the GLOWS instrument label Mar 30, 2026
@maxinelasp maxinelasp added this to IMAP Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GLOWS processing to align with renamed ancillary dependency descriptors and begins plumbing the L2 calibration ancillary through to the L2 processing entrypoint (to support upcoming cps-to-Rayleigh calibration work).

Changes:

  • Renames GLOWS ancillary dependency descriptors used by the CLI to the new l1b-* names.
  • Adds a calibration_dataset parameter to glows_l2 and passes a combined calibration dataset from the CLI.
  • Updates the GLOWS L2 unit test to call glows_l2 with the new argument.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
imap_processing/tests/glows/test_glows_l2.py Updates test calls to glows_l2 to include the newly added calibration argument.
imap_processing/glows/l2/glows_l2.py Extends the glows_l2 API/docstring to accept a calibration dataset.
imap_processing/cli.py Switches to renamed ancillary descriptors and wires l2-calibration into the GLOWS L2 invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. This setups nicely for that ticket mentioned in the PR and upcoming work!

@maxinelasp maxinelasp merged commit f257828 into IMAP-Science-Operations-Center:dev Mar 30, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this to Done in IMAP Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ins: GLOWS Related to the GLOWS instrument

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants