GLOWS Ancillary file rename#2887
Merged
maxinelasp merged 2 commits intoIMAP-Science-Operations-Center:devfrom Mar 30, 2026
Merged
GLOWS Ancillary file rename#2887maxinelasp merged 2 commits intoIMAP-Science-Operations-Center:devfrom
maxinelasp merged 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GLOWS processing to align with renamed ancillary dependency descriptors and begins plumbing the L2 calibration ancillary through to the L2 processing entrypoint (to support upcoming cps-to-Rayleigh calibration work).
Changes:
- Renames GLOWS ancillary dependency descriptors used by the CLI to the new
l1b-*names. - Adds a
calibration_datasetparameter toglows_l2and passes a combined calibration dataset from the CLI. - Updates the GLOWS L2 unit test to call
glows_l2with the new argument.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
imap_processing/tests/glows/test_glows_l2.py |
Updates test calls to glows_l2 to include the newly added calibration argument. |
imap_processing/glows/l2/glows_l2.py |
Extends the glows_l2 API/docstring to accept a calibration dataset. |
imap_processing/cli.py |
Switches to renamed ancillary descriptors and wires l2-calibration into the GLOWS L2 invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tech3371
approved these changes
Mar 30, 2026
Contributor
tech3371
left a comment
There was a problem hiding this comment.
looks good. This setups nicely for that ticket mentioned in the PR and upcoming work!
f257828
into
IMAP-Science-Operations-Center:dev
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Address the changes in #2878 to rename ancillary files used.
This also passes the calibration file through to L2 processing to make #2886 easier.
As a note: this will not run in production without the matching changes in sds-data-manager (PR up now.)