Sync dev to dependency_refactor branch#1196
Closed
tech3371 wants to merge 34 commits intodependency_refactorfrom
Closed
Sync dev to dependency_refactor branch#1196tech3371 wants to merge 34 commits intodependency_refactorfrom
tech3371 wants to merge 34 commits intodependency_refactorfrom
Conversation
* SWAPI now able to use predicted ephemeris for Swapi L3a proton-sw, pui-he * Allow SWE L3 to trigger with only predicted ephemeris * Switch reconstructed/predicted order for consistency with other dependencies --------- Co-authored-by: Menlo Innovations - CAVA Project <harrison@menloinnovations.com>
Co-authored-by: Menlo Innovations - CAVA Project <harrison@menloinnovations.com>
* Remove SWAPI l3a proton-sw dependency on ephemeris SPICE kernels and make SWE trigger off predicted ephemeris. We discovered SWAPI l3a proton does not require ephemeris data. Previously SWE did not have to be triggered by ephemeris, because we knew it was available if proton-sw was created. Since proton-sw no longer depends on ephemeris, it is important for SWE to trigger of this in case predicted ephemeris is the last SWE dependency to become available. * Do not trigger SWAPI pui-he on reconstructed ephemeris predicted ephemeris should be sufficient for the pickup ion computation. Removing this triggering dependency prevents excess versions of the file being produced. --------- Co-authored-by: Menlo Innovations - CAVA Project <harrison@menloinnovations.com>
* Loading in leapseconds before converting YYYYMMDD to J2000
Changed how we search to fill in gaps in the metakernel, speeding things up considerably
* special handling for idex files
* Modify dependency.get_files() to be able to query across multiple repointings * Add special handling for hi goodtimes in dependency.get_jobs * Add test coverage for custom handling of Hi Goodtimes jobs in batch_starter * Fix change in monkeypatch due to different import * Add mock for get_dependencies * Address copilot PR review * Update configuration variables to be the requested +/- 3 repoints * Add function for getting n nearest pointings/days * Add modify custom handling of hi goodtimes jobs in batch starter and dependency_api * Refactor and improvents * Switch hi goodtimes to L1B product * Copilot feedback changes * Fix incorrect keyword
* skip daily file check for IDEX * remove todo
* skip daily file check for IDEX * remove todo * fix batch starter bug * pr comments
Add hi l1b goodtimes as upstream dependency to hi l1c pset
* fix bug * add log * pr comments
* idex evt -> msg also add an l1b msg job * fix idex test
* set batch starter timeout to 15 mins * comment
* set first map date and default reprocessing start date * update comment
Contributor
Author
|
I like to look into different solution to track increment progress of refactoring work. Our PR merge default setting is 'squash and merge' and I want avoid doing that for future merge into dev. It will cause to wipe away commits in dev and merge them into one commit. I like to avoid that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
File changes
Testing