Open
Conversation
- replace hardcoded service names with dynamic Helm template functions - add helper templates for PostgreSQL and ClickHouse service name generation - support external database services via externalServiceName config - automatically generate database URLs when not explicitly provided - maintain backward compatibility with existing configurations fixes issue where database URLs used static service names instead of release-specific names, causing connection failures in multi-release deployments
Author
|
Fixes #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chart currently uses hardcoded service names in the default database
URLs:
This causes connection failures in multi-release deployments where the
actual service names include the release name (e.g.,
my-release-plausible-analytics-postgresql).
Solution
This PR introduces dynamic service name generation using Helm template
functions:
New helper templates:
PostgreSQL service name
ClickHouse service name
connection URL
connection URL
Configuration changes:
configuration
Example
Before (hardcoded):
postgres://postgres:postgres@plausible-analytics-postgresql:5432/plausible
_db
After (dynamic):
postgres://postgres:postgres@my-release-plausible-analytics-postgresql:543
2/plausible_db
Testing
Breaking Changes
None - this change is fully backward compatible.
Files changed:
generation
provided
Fixes connection issues in multi-release environments and improves chart
flexibility for various deployment scenarios.