Replace use_base option by a generic use_variant option.#9
Open
Replace use_base option by a generic use_variant option.#9
use_base option by a generic use_variant option.#9Conversation
This commit generalizes the `use_base: True` option by replacing it by a new `use_variant` option, which takes the name of the ontology variant to use as an argument. For any given import IMP, setting `use_variant` to `FOO` instructs the ODK to download the IMP ontology from `http://purl.obolibrary.org/obo/IMP/IMP-FOO.owl`. This option is intended to make it easier to import arbitrary ontology variants without having to always specify their full URL using `mirror_from`. The old `use_base: True` option is exactly equivalent to `use_variant: base`, and whenever the old option is encountered in a configuration file, it is automatically interpreted as such. closes INCATools/ontology-development-kit#1321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
use_base: Trueoption by replacing it by a newuse_variantoption, which takes the name of the ontology variant to use as an argument.For any given import IMP, setting
use_varianttoFOOinstructs the ODK to download the IMP ontology fromhttp://purl.obolibrary.org/obo/IMP/IMP-FOO.owl.This option is intended to make it easier to import arbitrary ontology variants without having to always specify their full URL using
mirror_from.The old
use_base: Trueoption is exactly equivalent touse_variant: base, and whenever the old option is encountered in a configuration file, it is automatically interpreted as such.closes INCATools/ontology-development-kit#1321