Ticket 3240: ZOOM no longer creating putlogs#183
Open
DominicOram wants to merge 5 commits intomasterfrom
Open
Conversation
DominicOram
commented
Jan 8, 2019
| if not force and ioc.startswith(IOCS_NOT_TO_STOP): | ||
| return | ||
| try: | ||
| auto = self._proc.get_autorestart(ioc) |
Contributor
Author
There was a problem hiding this comment.
Note that my refactoring removed this line, which was the one originally failing the ticket.
Contributor
|
See the added notes in the main post of ticket thread. The issue is fixed for the blockserver but IOC's can still cause the putlogging from the IOC Log Server to die. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Modified the ISIS logger to only send valid XML to the log server
See ISISComputingGroup/IBEX#3240
To Test
Code Review
Functional Tests
Final steps