Ticket3396 show global macros

[Chsudeepta]

Description of work

GUI changes to show macro setting from globals.txt

Ticket

This address the issue described here

Acceptance criteria

1. The GUI should show the globals.txt macro settings in a separate tab in the edit/view configuration dialog.
2. The data should be shown in a sortable table.
3. The code should acceptable coding standards.

---

Code Review

• Is the code of an acceptable quality?
• If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
• Do the changes function as described and is it robust?
• Is there associated PR for the release notes?

Final Steps

• Reviewer has also merged the release notes

[davidkeymer]

Suggested change

	macros = (globalmacros == null) ? new ArrayList<>()
	: globalmacros.stream().sorted().filter(Objects::nonNull)
	.flatMap(macro -> macro.getMacros().entrySet().stream().sorted(Map.Entry.comparingByKey()).map(
	entry -> new GlobalMacroViewModel(macro.getName(), entry.getKey(), entry.getValue())))
	.collect(Collectors.toList());
	}
	if (globalmacros == null) {
	macros = new ArrayList<>();
	return;
	}
	macros = globalmacros.stream()
	.sorted()
	.filter(Objects::nonNull)
	.flatMap(macro ->macro.getMacros()
	.entrySet()
	.stream()
	.sorted(Map.Entry.comparingByKey())
	.map(entry -> new GlobalMacroViewModel(
	macro.getName(),
	entry.getKey(),
	entry.getValue()
	))
	)
	.collect(Collectors.toList());
	}

[Chsudeepta]

Reformatted the code

[davidkeymer]

try deleting this constructor.

[davidkeymer]

instead of IOC_SEPARATOR we could use something like <All IOCs> to make it much easier to understand?

[Chsudeepta]

The IOC_SEPARATOR is __ as it is used in the globals.txt. The logic additionally expects that if a macro value is true for all IOCs, then the block server will group them under the name __, ie without any IOC name