Conversation
Delete ScaledNamedDimsArray, ConjNamedDimsArray, AddNamedDimsArray, MulNamedDimsArray and all associated overloads. Broadcasting already works via broadcasted_denamed without these types. Contraction works via mul_nameddims which denames directly. Also remove TA.add! overload for named arrays — denaming happens before add! is reached in the broadcasting path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 26, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 72.10% 70.88% -1.22%
==========================================
Files 21 20 -1
Lines 1000 965 -35
==========================================
- Hits 721 684 -37
- Misses 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to ITensor/TensorAlgebra.jl#156 — removes the macro-generated lazy types that are no longer needed with the new LinearBroadcasted design.
What changed
Why this works
NamedDimsArrays broadcasting was already implemented correctly via broadcasted_denamed — it recursively denames the Broadcasted tree and delegates to the underlying arrays' broadcasting. The lazy types were only used by explicit *_l/+_l/conjed calls, which nothing depends on.
Contraction via * eagerly denames and contracts via mul_nameddims. mul! denames and calls contractadd!.
Deferred
Dependencies
Test plan
Generated with Claude Code