Skip to content

Add strict types to Connection::prepexec() #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukhwinder33445 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

Add strict types to Connection::prepexec() #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,12 @@ public function yieldPairs(Select|string $stmt, ?array $values = null): Generato
/**
* Prepare and execute the given statement
*
* @param Delete|Insert|Select|Update|string $stmt The SQL statement to prepare and execute
* @param string|array $values Values to bind to the statement, if any
* @param Delete|Insert|Select|Update|string $stmt The SQL statement to prepare and execute
* @param string|array|null $values Values to bind to the statement, if any
*
* @return PDOStatement
*/
public function prepexec($stmt, $values = null)
public function prepexec(Delete|Insert|Select|Update|string $stmt, string|array|null $values = null): PDOStatement
{
if ($values !== null && ! is_array($values)) {
$values = [$values];
Expand Down
7 changes: 6 additions & 1 deletion src/Test/TestConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
namespace ipl\Sql\Test;

use ipl\Sql\Connection;
use ipl\Sql\Delete;
use ipl\Sql\Insert;
use ipl\Sql\Select;
use ipl\Sql\Update;
use PDOStatement;

/**
* Config-less test connection
Expand Down Expand Up @@ -34,7 +39,7 @@ public function rollbackTransaction(): bool
throw new \LogicException('Transactions are not supported by the test connection');
}

public function prepexec($stmt, $values = null)
public function prepexec(Delete|Insert|Select|Update|string $stmt, string|array|null $values = null): PDOStatement
{
if (PHP_MAJOR_VERSION >= 8) {
return new class extends \PDOStatement {
Expand Down
Loading