Add strict type declarations and modernize codebase by sukhwinder33445 · Pull Request #63 · Icinga/ipl-stdlib

sukhwinder33445 · 2025-12-09T08:50:47Z

Add strict type declarations to all method parameters, return types,
and properties throughout the codebase. Remove redundant runtime type
checks now enforced by the type system. Update PHPDoc to use nullable
shorthand, consistent union type ordering, and compact format.

Replace list() with array destructuring, switch/case with match
expressions, and self return types with static for better fluent
interface support.

Breaking changes — consumers of the following APIs require updates:

Translator (ipl-i18n: GettextTranslator, NoopTranslator)
Paginatable (ipl-sql: Cursor, LimitOffset)
Messages::addMessage() (ipl-html: Contract/FormElement)
Properties::getProperty() (ipl-orm: Common/PropertiesWithDefaults)
Raise the minimum PHP version to 8.2

Intentionally left without type declarations:

Validator interface: too many overrides in consumers
Events::on(): must match Evenement\EventEmitterInterface
Messages::getMessage(): must match Validator interface

closes #30

BastianLedererIcinga

The return type of BaseFilter::setBaseFilter can be changed to static.

src/Filter.php

tests/Loader/TestPluginLoader.php

src/Seq.php

src/BaseFilter.php

src/Filter.php

The base branch was changed.

sukhwinder33445 · 2026-01-07T16:09:07Z

Please rebase.

src/Filter.php

src/Contract/Translator.php

sukhwinder33445 · 2026-03-03T07:30:21Z

ipl\Stdlib\Messages::getMessage()
(without return type to match the definition of the interface ipl\Stdlib\Contract\Validator)

I assume you mean the getMessages() method. However, it already declares a return type in both the mentioned trait and the interface. Since both are part of ipl-stdlib, the return type can be added there.

sukhwinder33445

Everything else looks good to me.

src/functions.php

src/Filter/Condition.php

src/Plugins.php

src/Contract/Validator.php

src/functions.php

src/Filter.php

sukhwinder33445

Looks good to me.

Add strict type declarations to properties, function/method signatures, where types are unambiguous and no inheritance is affected. Remove any now superfluous type checks. PHPDoc adjusted: nullable shorthand, union type ordering, compact format. Raise minimum PHP version to 8.0. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>

Raise minimum PHP version to 8.2. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>

This change requires adjustments to the following consumers: ipl-html: - src/Contract/FormElement.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

This change requires adjustments to the following consumers: ipl-orm: - src/Common/PropertiesWithDefaults.php

This change requires adjustments to the following consumers: ipl-sql - src/Cursor.php - src/LimitOffset.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

This change requires adjustments to the following consumers: ipl-i18n - src/GettextTranslator.php - src/NoopTranslator.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

jrauh01

I have some change suggestions.

src/Filter/Chain.php

src/Filter/MetaData.php

src/Plugins.php

src/Str.php

src/functions.php

src/Seq.php

lippserd · 2026-03-24T13:47:08Z

I have some change suggestions.

You can push your changes directly as a single commit, if you want.

- Replace `array_search() !== false` with `in_array()` in `Chain::has()` - Replace null-check-and-assign with `??=` in `MetaData::metaData()` - Replace if/else variable assignment with ternary in `Plugins::createLoader()` - Replace `isset($a[$k]) ? $a[$k] : null` with `$a[$k] ?? null` in `Seq::findByKey()` - Replace manual `substr()` prefix check with `str_starts_with()` in `Str::startsWith()` - Collapse if/else around `explode()` into a single ternary in `Str::trimSplit()` - Replace if/else with ternary in `get_php_type()` - Drop unused loop key in `iterable_value_first()`

sukhwinder33445 assigned Jan-Schuppik Dec 9, 2025

cla-bot bot added the cla/signed label Dec 9, 2025

sukhwinder33445 changed the base branch from main to support-php-85 December 9, 2025 08:50

BastianLedererIcinga mentioned this pull request Dec 9, 2025

Add non-breaking strict type declarations Icinga/ipl-i18n#26

Merged

Jan-Schuppik requested a review from BastianLedererIcinga December 9, 2025 13:36

sukhwinder33445 force-pushed the support-php-85 branch from 52f1357 to 415ad2b Compare December 9, 2025 14:39

sukhwinder33445 force-pushed the modernize-code branch from 4bc935f to 422c34e Compare December 9, 2025 14:39

BastianLedererIcinga reviewed Dec 10, 2025

View reviewed changes

src/Filter.php Outdated Show resolved Hide resolved

BastianLedererIcinga reviewed Dec 10, 2025

View reviewed changes

tests/Loader/TestPluginLoader.php Outdated Show resolved Hide resolved

BastianLedererIcinga reviewed Dec 10, 2025

View reviewed changes

src/Seq.php Outdated Show resolved Hide resolved

BastianLedererIcinga previously approved these changes Dec 10, 2025

View reviewed changes

sukhwinder33445 force-pushed the modernize-code branch from 01fc4fa to 2030a2d Compare December 10, 2025 14:24

sukhwinder33445 commented Dec 10, 2025

View reviewed changes

src/BaseFilter.php Outdated Show resolved Hide resolved

src/Filter.php Outdated Show resolved Hide resolved

src/Filter.php Outdated Show resolved Hide resolved

src/Filter.php Outdated Show resolved Hide resolved

src/Filter.php Outdated Show resolved Hide resolved

Jan-Schuppik force-pushed the modernize-code branch from 5c7ad36 to 0e8fbc5 Compare December 11, 2025 08:29

sukhwinder33445 force-pushed the support-php-85 branch 2 times, most recently from 6408fa8 to d67ed2a Compare December 12, 2025 07:44

sukhwinder33445 force-pushed the support-php-85 branch from d67ed2a to dd095bd Compare December 18, 2025 12:23

Base automatically changed from support-php-85 to main January 7, 2026 14:54

Jan-Schuppik force-pushed the modernize-code branch from 0e8fbc5 to 20d500b Compare January 7, 2026 19:43

sukhwinder33445 commented Jan 13, 2026

View reviewed changes

src/Filter.php Outdated Show resolved Hide resolved

src/Contract/Translator.php Show resolved Hide resolved

sukhwinder33445 mentioned this pull request Jan 23, 2026

Add strict type declarations and modernize codebase Icinga/ipl-sql#96

Merged

Jan-Schuppik mentioned this pull request Mar 2, 2026

Adjust modules for compatibility with ipl-stdlib modernization #68

Open

5 tasks

BastianLedererIcinga mentioned this pull request Mar 2, 2026

Adapt to ipl-stdlib strict typing Icinga/ipl-html#187

Merged

sukhwinder33445 commented Mar 3, 2026

View reviewed changes

src/functions.php Outdated Show resolved Hide resolved

src/Filter/Condition.php Outdated Show resolved Hide resolved

BastianLedererIcinga reviewed Mar 3, 2026

View reviewed changes

src/Plugins.php Outdated Show resolved Hide resolved

sukhwinder33445 commented Mar 3, 2026

View reviewed changes

src/Contract/Validator.php Outdated Show resolved Hide resolved

BastianLedererIcinga reviewed Mar 5, 2026

View reviewed changes

src/functions.php Outdated Show resolved Hide resolved

sukhwinder33445 commented Mar 5, 2026

View reviewed changes

src/Filter.php Outdated Show resolved Hide resolved

src/Filter.php Outdated Show resolved Hide resolved

src/Filter.php Show resolved Hide resolved

Jan-Schuppik force-pushed the modernize-code branch from 5ffb327 to 8a06264 Compare March 5, 2026 12:22

sukhwinder33445 commented Mar 5, 2026

View reviewed changes

sukhwinder33445 requested a review from lippserd March 5, 2026 12:44

lippserd mentioned this pull request Mar 12, 2026

Add strict types to GettextTranslator and NoopTranslator Icinga/ipl-i18n#13

Merged

2 tasks

Jan-Schuppik force-pushed the modernize-code branch from 8a06264 to 77be55b Compare March 12, 2026 16:54

Use array destructuring instead of list()

72ad9b4

lippserd force-pushed the modernize-code branch 3 times, most recently from 4a6fb1e to a5d07c8 Compare March 19, 2026 13:24

Jan-Schuppik and others added 8 commits March 19, 2026 14:46

PriorityQueue::insert(): Use standalone true return type

337b54d

Raise minimum PHP version to 8.2. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>

Replace return type self with static

6be366e

Replace switch statement with match expression

6b3cb14

Messages::addMessage(): Add strict type declarations

463f0ac

This change requires adjustments to the following consumers: ipl-html: - src/Contract/FormElement.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

Properties::getProperty(): Add strict type declarations

62bbcf0

This change requires adjustments to the following consumers: ipl-orm: - src/Common/PropertiesWithDefaults.php

Paginatable: Add strict type declarations

748894b

This change requires adjustments to the following consumers: ipl-sql - src/Cursor.php - src/LimitOffset.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

Translator: Add strict type declarations

f84582d

This change requires adjustments to the following consumers: ipl-i18n - src/GettextTranslator.php - src/NoopTranslator.php PHPDoc adjusted: nullable shorthand, union type ordering, compact format.

lippserd force-pushed the modernize-code branch from a5d07c8 to f84582d Compare March 19, 2026 13:46

lippserd added this to the v0.15.0 milestone Mar 19, 2026

lippserd changed the title ~~Modernize code~~ Add strict type declarations and modernize codebase Mar 20, 2026

lippserd mentioned this pull request Mar 20, 2026

Add strict type declarations and modernize codebase Icinga/ipl-orm#155

Merged

jrauh01 reviewed Mar 24, 2026

View reviewed changes

lippserd approved these changes Mar 24, 2026

View reviewed changes

lippserd changed the title ~~Add strict type declarations and modernize codebase~~ Add strict type declarations and modernize codebase Mar 24, 2026

lippserd merged commit 5049aa2 into main Mar 24, 2026
13 checks passed

lippserd deleted the modernize-code branch March 24, 2026 16:30

Conversation

sukhwinder33445 commented Dec 9, 2025 • edited by lippserd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BastianLedererIcinga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sukhwinder33445 commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

sukhwinder33445 commented Mar 3, 2026

Uh oh!

sukhwinder33445 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sukhwinder33445 left a comment

Choose a reason for hiding this comment

Uh oh!

jrauh01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lippserd commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sukhwinder33445 commented Dec 9, 2025 •

edited by lippserd

Loading