Merged
Conversation
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
from
eeea8a3 to
fa4befc
Compare
jrauh01
requested changes
Mar 23, 2026
jrauh01
requested changes
Mar 23, 2026
Contributor
jrauh01
left a comment
jrauh01
left a comment
There was a problem hiding this comment.
I marked a few things, I think would match the concern of this PR.
Additionally please correctly align the PHPDocs of the ignoresCase() method in:
ipl\Stdlib\Filter\Equalipl\Stdlib\Filter\Likeipl\Stdlib\Filter\Unqualipl\Stdlib\Filter\Unlike
jrauh01
requested changes
Mar 24, 2026
Contributor
jrauh01
left a comment
jrauh01
left a comment
There was a problem hiding this comment.
I just noticed that most of the class-level PHPDocs are single-lines like:
/** ... */
But some are still multi-line although they only contain a single line like:
/**
* ...
*/
The multi-line classes/interfaces are:
ipl\Stdlib\Contract\Translatoripl\Stdlib\Loader\AutoloadingPluginLoaderipl\Stdlib\Str
src/Plugins.php
Outdated
Contributor
There was a problem hiding this comment.
This inline type doc can be removed. The type can already be inferred from the new array<string, PluginLoader[]> property type doc.
Contributor
|
As the base branch |
Potential bugfix releases for maintained older versions should receive the same PHP checks as the default branch. Extend push builds to also cover `support/*` and drop the pull request target filter so validation still runs for pull requests merged through other pull requests. Enable `workflow_dispatch` for ad-hoc verification.
Enable Composer's `sort-packages` setting and run `composer normalize` to establish a consistent structure for `composer.json`. This keeps future dependency changes deterministic and reduces unnecessary diff noise.
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
2 times, most recently
from
b80e101 to
22a1083
Compare
Add a minimal `.gitattributes` file so `git archive` excludes CI and Git configuration files as well as test-related files. This keeps release archives focused on the package contents.
Remove the broad hidden file exclusion and its `.git*` whitelist in
favor of a global `~/.gitignore`. Editor and OS artifacts such as
`.DS_Store`, `.idea/`, or `.vscode/` are environment-specific and not
the project's responsibility to exclude.
Each developer should maintain a global ignore file for such artifacts:
git config --global core.excludesFile ~/.gitignore
Keep only Composer installation artifacts with a comment clarifying
why `composer.lock` is excluded for library projects.
Rename the license file to `LICENSE.md`, switch to a Markdown heading, and normalize the Icinga URL. This aligns the license file with the repository's Markdown-based documentation and establishes `LICENSE.md` as a consistent convention across all Icinga repositories.
Introduced changelog covers all releases and unreleased changes, derived from tags, release notes, commits, and related pull requests.
Add a package overview, installation requirements, and focused examples for the filter system, Events trait, and utility functions. This gives users practical guidance without turning the README into a component-by-component reference.
Inline comments should read as complete sentences and be easy to scan. Ending each comment with a full stop signals that the thought is complete and keeps the style consistent across the codebase. Where comments were verbose or imprecise, take the opportunity to tighten the wording without changing meaning.
All three methods accept zero rules, but the existing PHPDoc left callers to infer what the resulting rule would do. An empty `All` or `None` always matches; an empty `Any` never does. Co-authored-by: Dennis <47061464+dennisorlando@users.noreply.github.com>
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
from
22a1083 to
75355bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates several maintenance tasks to bring the repository in
line with shared conventions across our projects.
CI
support/*and trigger validation for all pullrequests regardless of the target branch.
workflow_dispatchfor ad‑hoc verification.Repository
.gitattributesto exclude CI, Git configuration, andtest‑related files from
git archiveoutputs.sort‑packagessetting and normalizecomposer.json.LICENSE.mdto align with the repository’sMarkdown‑based documentation and establish a consistent convention
across all repositories.
Documentation
CHANGELOG.mdto summarize notable changes per release.README.mdwith a package overview, installation requirements,and focused examples for the filter system, Events trait, and utility functions.
closes #67