Conversation
murraystevenson
left a comment
There was a problem hiding this comment.
Thanks John! Changes look good from my perspective. Great to see we're almost free of boost::format()...
|
@ivanimanishi, can I take your silence as approval? :) |
ivanimanishi
left a comment
There was a problem hiding this comment.
We'll have to update our internal repositories, but if I understand correctly, if we start using fmt::format() in our code, it should still work with older cortex (10.5 and 10.6), right (since it would just be returning an std::string)?
If that's the case, then I'm ok with approving this PR.
|
Yes, you'll be able to do |
We only have one owner, and `unique_ptr` makes that clear. I only spotted this after removing a `boost/format.hpp` include from another header. These two files weren't including `boost/shared_ptr.hpp` themselves, and were instead getting it transitively from the other header.
And replace with direct use of `fmt::format()` internally. This removes the final usage of `boost::format()` from Cortex.
6802662 to
48f2182
Compare
This fixes a couple of strays that escaped the purge in #1514, and a couple of associated issues. I found these by removing support for
boost::format()from the MessageHandler class. @ivanimanishi, if that is a step too far then just let us know and we can drop that commit from this PR. The single remainingboost::format()usage is now inFileSequence::fileNameTemplate(), which is a protected method. There are no derived classes that can make use of it in Cortex or Gaffer, so I wonder if IE has something internally using it, or if it should have been private all along. If the latter, then I'll remove it too.