Merged
Conversation
This will be useful in Gaffer, where there are a couple of spots where we must pass stack-allocated Cancellers to Python as raw pointers, and just hope that nobody accesses them after they expire. It also enables the next commit, where we allow cancellers to be chained.
This means that one canceller can automatically cancel others. It will be used in Gaffer, where multiple clients (each with their own canceller) may end up working on the same compute by virtue of task collaboration. Although this adds a mutex and additional state, the hot-path that we care about (`check()`), is unchanged. The mutex is only used rarely, when adding/removing children and at the point of cancellation.
So that the public API fits easily onto a single screen, without being cluttered with implementation detail.
johnhaddon
force-pushed
the
cancellerImprovements
branch
from
dc8a603 to
519cc90
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the Canceller class, in support of some upcoming cancellation improvements in Gaffer.