JET-2338: Add support for file scheme in dist URL#1
Open
kellinwood wants to merge 2 commits intodev-1.19from
Open
JET-2338: Add support for file scheme in dist URL#1kellinwood wants to merge 2 commits intodev-1.19from
kellinwood wants to merge 2 commits intodev-1.19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its a royal pain to have to get the flink-dist.tar.gz exposed via HTTP in order to do the docker build, so this change allows the generated Dockerfile to reference the tgz as a local file via
file:scheme.Note that this change also uses the
RUN --mount ...command in the Dockerfile which is not supported in older versions of docker. This mounts the build context dir (.) as/build-ctx, thus requiring the tgz file to be in the build context dir, and that the FLINK_TGZ_URL value must start withfile://build-ctx/