Register, Docker Compose, Fast API#12
Register, Docker Compose, Fast API#12hosseinjafar wants to merge 23 commits intoImagingDataCommons:mainfrom
Conversation
…t is to be tested from inside the python
…et's finish calling plastimatch
renamed dockerfiles with docker_src since this folder contains more than dockerfile.
|
Thank you for your contribution @hosseinjafar. The fast api implementation and updated docker file are interesting (and if they are of general interest to the community I suggest to make them publicly available in a separate repository that we can reference). As in the current state, the Dockerfile and Compose setup are quite specific (e.g., only the registration command you add to the package is published in the fast api, no description how the referenced test files can be acquired, ..). The path to the Dockerfile also should not be changed unless for a specific reason to maintain compatibility where possible. |
|
Fair enough! Best |
…s include:\n 1. replacing _ with - in the inputs for the convert command.\n 2. automatically removing \temp\ temp_data/ from all the inputs and adding the correct path for temp_data. implementing the api call for conver
…and not the dev command for the other containers to notice it
2 participants
Thanks for the nice package! I use a docker container with Ubuntu 24 on it. running
apt install plastimatchwas good enough to get everything to work. no need to install the compiled binaries in python manually.The following functionality was added along with documentation and unit tests:
Register:
The register command to the Plastimatch is now implemented in pyplastimatch.py the tests are placed in test/test_register.py.
Docker compose:
Simplifies volume mounting and environment setting when running a container.
FastAPI:
I use pyplastimatch on a remote cluster as a server. Implemented pyplasti.py to call register using http post request.