fixed defines for NK_SIZE_TYPE and NK_POINTER_TYPE on MinGW and windows clang/clang-cl.#811
Merged
RobLoach merged 5 commits intoImmediate-Mode-UI:masterfrom Feb 7, 2026
Merged
Conversation
fixed pointer and size type defs for MinGW64
Contributor
Author
|
I have not tested building with clang-cl inside Vistual Studio. |
sleeptightAnsiC
suggested changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Tested under MSYS2 UCRT64 and VS2022, and it indeed fixes this issue.
If you could only remove that one little space, it should be good to merge.
Just for reference, my environment is:
$ uname -a
MINGW64_NT-10.0-22631 QW11090824 3.6.4-23a25d49.x86_64 2025-07-16 16:15 UTC x86_64 Msys
$ gcc --version
gcc.exe (Rev8, Built by MSYS2 project) 15.2.0
$ clang-cl --version
clang version 21.1.0 (https://github.com/msys2/MSYS2-packages dd887afdaff2641f5919b53ef1286f484a8799a7)
** Visual Studio 2022 Developer Command Prompt v17.10.5
> cl /?
Microsoft (R) C/C++ Optimizing Compiler Version 19.40.33813 for x86
> clang-cl --version
clang version 17.0.3
RobLoach
reviewed
Feb 7, 2026
PavelSharp
pushed a commit
to PavelSharp/Nuklear
that referenced
this pull request
Feb 15, 2026
…/clang-cl (Immediate-Mode-UI#811) * Update nuklear.h fixed pointer and size type defs for MinGW64 * -- added __clang__ macro for windows clang and clang-cl to also work * updated the template nuklear.h to fix NK_SIZE_TYPE and NK_POINTER_TYPE * Update src/nuklear.h * Apply suggestion from @RobLoach --------- Co-authored-by: Rob Loach <RobLoach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue as stated in #810
modified defines for
NK_SIZE_TYPEandNK_POINTER_TYPEto:to account for MinGW 64 and 32 bit aswell as windows clang 64 and 32 bit and clang-cl 64 and 32 bit.
i've put together a quick goldbolt comparison
with MinGW gcc + clang and a gnu/linux gcc basecase, to demonstrate that the fix works as intended.