Skip to content

[Snyk] Fix for 2 vulnerabilities#18

Open
ashmuck wants to merge 1 commit intomainfrom
snyk-fix-46f95a957fa81b6e4f0f998484ed5913
Open

[Snyk] Fix for 2 vulnerabilities#18
ashmuck wants to merge 1 commit intomainfrom
snyk-fix-46f95a957fa81b6e4f0f998484ed5913

Conversation

@ashmuck
Copy link
Copy Markdown

@ashmuck ashmuck commented Mar 27, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Infinite loop
SNYK-JS-BRACEEXPANSION-15789759
  641  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-15789761
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)


Note

High Risk
Upgrading rimraf from v3 to v6 introduces a new Node.js engine requirement (>=20), which may break installs/builds in environments that still follow the project’s current node >=10 engine range. The express bump is smaller but still affects request routing/parsing dependencies and should be smoke-tested.

Overview
Updates runtime dependencies to remediate reported Snyk issues by upgrading express to 4.22.0 and rimraf to 6.1.1.

The lockfile is refreshed accordingly, pulling in newer transitive packages (notably around glob/minimatch and qs under express) and reflecting updated dependency constraints and metadata.

Written by Cursor Bugbot for commit 2c7832d. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

"multistream": "^2.1.1",
"mysql2": "^3.10.1",
"rimraf": "^3.0.2",
"rimraf": "^6.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major rimraf version bump breaks production code API

High Severity

Upgrading rimraf from ^3.0.2 to ^6.1.1 is a breaking major version change. The production code in src/common/utils/utils.ts does import rimraf = require("rimraf") followed by promisify(rimraf), relying on the callback-based API of v3. In v6, rimraf returns a Promise natively, has no default export (requires named import { rimraf }), and doesn't accept callbacks. This will cause rimrafAsync to malfunction, breaking all clean() operations across LokiBlobMetadataStore, FSExtentStore, and LokiExtentMetadataStore. The test file tests/testutils.ts also uses the v3 callback-style API directly.

Additional Locations (1)
Fix in Cursor Fix in Web

"axios": "^0.27.0",
"etag": "^1.8.1",
"express": "^4.16.4",
"express": "^4.22.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js engine requirement conflict with rimraf 6

Medium Severity

The project declares "node": ">=10.0.0" in its engines field, but rimraf 6.1.1 (and its dependencies like glob 12, jackspeak 4, path-scurry 2) require "node": "20 || >=22". Users running on Node.js 14, 16, or 18 — which the project explicitly claims to support — will encounter failures at runtime from these dependencies.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants