Fix EOL related build issues on Windows#2077
Merged
mark9064 merged 2 commits intoInfiniTimeOrg:mainfrom Feb 11, 2025
Merged
Conversation
|
Build size and comparison to main:
|
NeroBurner
reviewed
Sep 18, 2024
Contributor
NeroBurner
left a comment
There was a problem hiding this comment.
looking good. No change in behavior on supported platforms (i.e. Linux) and possible fix for Windows builds. Just suggesting a few comments for future "us" to know why we don't have native line endings
f06149e to
a44d00a
Compare
NeroBurner
approved these changes
Sep 19, 2024
Contributor
NeroBurner
left a comment
There was a problem hiding this comment.
looking good. I'm scheduling for 1.16.0 as 1.15.0 feels close
1 task
Member
|
If you rebase this onto main the CI should work now #2166 is merged |
a44d00a to
071c9ce
Compare
Contributor
Author
done |
only affects windows users
add reminder why this is necessary directly to file Co-authored-by: NeroBurner <pyro4hell@gmail.com>
071c9ce to
6e09d57
Compare
mark9064
approved these changes
Feb 11, 2025
dariusarnold
pushed a commit
to dariusarnold/InfiniTime
that referenced
this pull request
Mar 2, 2025
Prevent line endings from getting normalised to CRLF Co-authored-by: NeroBurner <pyro4hell@gmail.com>
BurninTurtles
pushed a commit
to BurninTurtles/InfiniTimeBT
that referenced
this pull request
Mar 3, 2025
Prevent line endings from getting normalised to CRLF Co-authored-by: NeroBurner <pyro4hell@gmail.com>
BurninTurtles
pushed a commit
to BurninTurtles/InfiniTimeBT
that referenced
this pull request
Mar 3, 2025
Prevent line endings from getting normalised to CRLF Co-authored-by: NeroBurner <pyro4hell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper fix for #1275 that does no longer require manual intervention.
On Windows, git has
core.autocrlf=trueset at system level, hence any Windows user who has not changed their global git config will checkout all text files with CRLF line endings. For some files this seems to cause build issues.With this change, I can build using docker on Windows 11 as follows:
Without the change, the build fails with an error that matches the one described in #1275:
Note: when changing between branches with varying
.gitattributeswithcheckoutinstead of directly cloning with--branch, resetting the line endings is more complicated: