Skip to content

Resolve paint corrupting screen scrolling#2324

Merged
mark9064 merged 1 commit intoInfiniTimeOrg:mainfrom
mark9064:paint-fix
Oct 10, 2025
Merged

Resolve paint corrupting screen scrolling#2324
mark9064 merged 1 commit intoInfiniTimeOrg:mainfrom
mark9064:paint-fix

Conversation

@mark9064
Copy link
Member

@mark9064 mark9064 commented Jun 27, 2025

Closes #2034

The main problem is calling FlushDisplay while scrolling causes bad behaviour

@mark9064 mark9064 added this to the 1.16.0 milestone Jun 27, 2025
@mark9064 mark9064 added the bug Something isn't working label Jun 27, 2025
@github-actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 380164B 32B
data 944B 0B
bss 22544B 0B

Run in InfiniEmu

@mark9064
Copy link
Member Author

mark9064 commented Jun 27, 2025

Simulator needs IsScrolling copied over

NeroBurner
NeroBurner approved these changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the code. But it looks sound. Could you open a PR on InfiniSim an I'll merge it over there. As it is a new function merging it won't break stuff

@mark9064
Copy link
Member Author

mark9064 commented Oct 7, 2025 •
edited
Loading

Opened InfiniTimeOrg/InfiniSim#182

I haven't tested infinisim with this at all yet, it definitely fixes on HW (not sure if issue reproduced on sim before either)

Edit: If sim CI is green we should retrigger CI here before merging just to check it's all good - I haven't tested the sim build

@NeroBurner
Copy link
Contributor

NeroBurner commented Oct 8, 2025 •
edited
Loading

Fixed link to InfiniSim PR: InfiniTimeOrg/InfiniSim#182

already in the fixed edit, I clicked on the original wrong link in the EMail notification. Sorry for the noise

@NeroBurner NeroBurner mentioned this pull request Oct 8, 2025
Merged
NeroBurner pushed a commit to InfiniTimeOrg/InfiniSim that referenced this pull request Oct 8, 2025
@mark9064
Update for paint fix PR (#182)
403a3eb 
Upstream PR: InfiniTimeOrg/InfiniTime#2324
@mark9064
Copy link
Member Author

mark9064 commented Oct 9, 2025

@NeroBurner CI all green now, OK to merge?

NeroBurner
NeroBurner approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes looks good to me!

@mark9064 mark9064 merged commit 8422923 into InfiniTimeOrg:main Oct 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Screen shifting upwards

2 participants

@mark9064 @NeroBurner