[Surprise Exam] Fix plugin build issue related to Gson#57
Merged
Conversation
- Inject RuneLite's Gson object - Rename and refactored EXAM_QUESTION_GSON_LOGGER -> gsonExamQuestionLogger - Gson logger is now built and destroyed in onStartUp and onShutdown respectively - Solves the plugin build issue of "uses terminally deprecated APIs" regarding creating "fresh Gson instances"
- Fix plugin build issue related to creating a fresh Gson instance instead of using RuneLite's - (surpriseexam) Refactored Gson exam question logger to be built via RuneLite's Gson instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the plugin hub build issue due to using my own Gson builder instead of utilizing the one provided by RuneLite via injection instead.
refactor(surpriseexam): Now uses RuneLite's Gson to build the question logger