Skip to content

expose silent arg in get_geodata#261

Merged
tfardet merged 4 commits intomasterfrom
feat/add-silence-to-get-geodata
Mar 26, 2026
Merged

expose silent arg in get_geodata#261
tfardet merged 4 commits intomasterfrom
feat/add-silence-to-get-geodata

Conversation

@tgrandje
Copy link
Copy Markdown
Collaborator

@tgrandje tgrandje commented Mar 6, 2025

This exposes the silent arg in get_geodata (it was only accessible in the inner _get_geodata function) and pass it to the private function.

Also fix snake case for crs_polygon.

@tgrandje tgrandje requested a review from tfardet March 6, 2025 22:44
Comment thread pynsee/geodata/get_geodata.py
@tfardet
Copy link
Copy Markdown
Collaborator

tfardet commented Mar 19, 2026

for some reason I cannot seem to rerun the tests... I wanted to check what went wrong... @tgrandje can you do it?

@tgrandje
Copy link
Copy Markdown
Collaborator Author

nope, not available to me either. I'll try to make a dummy commit but I'm afraid if we have a failure due to localdata (as I think we have), we're not gonna fix the tests here either.

@tgrandje
Copy link
Copy Markdown
Collaborator Author

@tfardet that one's good to go

@tfardet tfardet merged commit af687a1 into master Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants