Add validation for LabelAttentionClassifier head configuration#61
Merged
meilame-tayebjee merged 3 commits into24-add-cross-attention-labels-textfrom Jan 27, 2026
Merged
Conversation
Co-authored-by: meilame-tayebjee <114609737+meilame-tayebjee@users.noreply.github.com>
…essages Co-authored-by: meilame-tayebjee <114609737+meilame-tayebjee@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update cross attention labels text implementation
Add validation for LabelAttentionClassifier head configuration
Jan 26, 2026
meilame-tayebjee
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LabelAttentionClassifierwas missing validation for head configuration constraints, allowing invalid configurations that cause shape mismatches at runtime whenembedding_dimis not divisible byn_head.Changes
LabelAttentionClassifier.__init__:embedding_dimmust be divisible byn_head(prevents shape mismatch inc_projlayer)n_headmust be divisible byn_kv_head(required for Group Query Attention)TextEmbeddervalidation pattern for consistencyExample
Invalid configurations now fail fast with clear error messages:
Previously this would fail later with cryptic tensor shape errors in
c_proj.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.