Skip to content

Comments

BUG: Do not specify GTest targets as LIBRARIES for ITKGoogleTest#4966

Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:googletest_system
Feb 19, 2026
Merged

BUG: Do not specify GTest targets as LIBRARIES for ITKGoogleTest#4966
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:googletest_system

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Nov 20, 2024

May address: #303

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Nov 20, 2024
@blowekamp
Copy link
Member Author

blowekamp commented Nov 20, 2024

The GTest libraries should not be a build time dependency of an installed ITK, but not sure how to disable the GTest libraries in an installed ITK.

@dzenanz dzenanz requested a review from bradking November 20, 2024 21:27
bradking
bradking reviewed Nov 20, 2024
View reviewed changes
@bradking
Copy link
Member

bradking commented Nov 20, 2024

not sure how to disable the GTest libraries in an installed ITK.

One needs to make sure nothing depends on them publicly. Then they shouldn't need to be installed.

@blowekamp
Copy link
Member Author

blowekamp commented Nov 20, 2024

not sure how to disable the GTest libraries in an installed ITK.

One needs to make sure nothing depends on them publicly. Then they shouldn't need to be installed.

In all "itk-module.cmake" files, if used, it is under "TEST_DEPENDS".

@bradking
Copy link
Member

bradking commented Nov 21, 2024

Off the top of my head I don't see why TEST_DEPENDS in the build tree should affect requirements in the install tree, at least conceptually.

hjmjohnson
hjmjohnson approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@hjmjohnson hjmjohnson self-requested a review December 13, 2024 12:00
@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Jan 23, 2025
@thewtex
Copy link
Member

thewtex commented Oct 27, 2025

@blowekamp should this be integrated?

@blowekamp
BUG: Do not specify GTest targets as LIBRARIES for ITKGoogleTest
8dd7198 
The ITKGoogleTest_LIBRARIES variable must not specify the GoogleTest
targets. This variable is exported for installation, but the targets
are not. This may results in users of an installed ITK which use
ITK_LIBRARIES to attempt to link to non-existing GTest Targets.
@blowekamp blowekamp requested a review from dzenanz February 18, 2026 17:49
@blowekamp
Copy link
Member Author

blowekamp commented Feb 18, 2026 •
edited
Loading

This PR has been updated with a better solution.

P.S. This solution could be applied to release-5.4 if needed.

@blowekamp blowekamp marked this pull request as ready for review February 19, 2026 13:26
@blowekamp blowekamp changed the title BUG: Include find GTest CMake code when installed BUG: Do not specify GTest targets as LIBRARIES for ITKGoogleTest Feb 19, 2026
@blowekamp blowekamp merged commit 2253b91 into InsightSoftwareConsortium:main Feb 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradking bradking bradking left review comments

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

@blowekamp blowekamp

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

ITK 6.0 Beta 2

Development

Successfully merging this pull request may close these issues.

5 participants

@blowekamp @bradking @thewtex @hjmjohnson @dzenanz