ENH: Support installation of FILE_SET HEADER for module targets#5801
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Feb 18, 2026
Merged
Conversation
github-actions
bot
added
type:Infrastructure
dzenanz
approved these changes
Feb 13, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I don't exactly understand the problem, but I have no objections to this change.
blowekamp
commented
Feb 13, 2026
CMake/ITKModuleMacros.cmake
Outdated
| ARCHIVE | ||
| DESTINATION ${${itk-module}_INSTALL_ARCHIVE_DIR} | ||
| COMPONENT Development | ||
| FILE_SET |
Member
Author
There was a problem hiding this comment.
Per CMake documentation this was added in CMake 3.23:
https://cmake.org/cmake/help/latest/command/install.html
ITK currently requires only 3.22.
This require CMake >=3.23, which remote modules can optionally do. Using FILE_SET property allows associating header files with a target, simplifying include paths and installation.
blowekamp
force-pushed
the
install_file_set_headers
branch
from
49140ed to
b439948
Compare
Member
Author
This PR optionally add support for FILE_SET properties on targets if the CMake version support it.While proxTV change is outside the scope of this PR, it is the motivation for this change. Using this feature greatly simplifies the third party library installation. |
dzenanz
approved these changes
Feb 17, 2026
hjmjohnson
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes relate to installation and include of headers with proxTV for the TotalVariations remote module:
phcerdan/proxTV@use_eigen...phcerdan:proxTV:itk_installation
For proxTV, instead of tracking all the variable and installation code the header files are associated with the proxTV::proxTB with as a FILE_SET. The installation and appropriate include paths are easier manages by the ITK's module macros.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.