BUG: Math::Absolute(-0.0) should return "plus zero" (+0.0)#5809
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Feb 17, 2026
Merged
BUG: Math::Absolute(-0.0) should return "plus zero" (+0.0)#5809hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom
Math::Absolute(-0.0) should return "plus zero" (+0.0)#5809hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Testing
dzenanz
approved these changes
Feb 17, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
😄
Of course, it needs to pass before merging.
Contributor
Author
I'm doing TDD 😃 Update: Yes, it's failing! At https://open.cdash.org/tests/2407046144 |
hjmjohnson
reviewed
Feb 17, 2026
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
@N-Dekker Thank you! If this fails/does not fail, I think the test is good. The fix is good, also. I'll keep an eye on this today, hopefully, and resolve this corner case soon.
Member
|
@N-Dekker I don't think there is a need for all the tests to fail. A sufficient number have demonstrated the problem that the fix and be included now. 569 - itkMath.AbsoluteMinusZeroReturnsPlusZero (Failed) |
Contributor
Author
|
@hjmjohnson No worries, I'm preparing a fix (to be proposed). 😇 |
Adjusted `Absolute(T)` to ensure that `Absolute(-0.0)` returns `+0.0`. Added a unit test, `AbsoluteMinusZeroReturnsPlusZero`.
N-Dekker
force-pushed
the
AbsoluteMinusZero
branch
from
784e676 to
28ee565
Compare
N-Dekker
changed the title
Math::Absolute(-0.0) returns "plus zero"Math::Absolute(-0.0) should return "plus zero" (+0.0)
dzenanz
approved these changes
Feb 17, 2026
hjmjohnson
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted
Absolute(T)to ensure thatAbsolute(-0.0)returns+0.0.Added a unit test,
AbsoluteMinusZeroReturnsPlusZero.