COMP: Use ImageConstIterator::ComputeIndex() in Review module#5810
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:mainfrom Feb 18, 2026
Conversation
Replaced function calls of the form `iterator.GetIndex()` with
`iterator.ComputeIndex()`, for iterators derived from `ImageConstIterator`, in
"Modules/Nonunit/Review"
Fixes compile errors that occur when compiling with `Module_ITKReview=ON` _and_
`ITK_FUTURE_LEGACY_REMOVE=ON`, like:
error: no member named 'GetIndex' in 'itk::ImageRegionConstIterator'
As occurred at RogueResearch24/Mac13.x-AppleClang-dbg-Universal:
https://open.cdash.org/viewBuildError.php?buildid=11052824
Reported by Bradley Lowekamp at
InsightSoftwareConsortium#5803 (comment)
dzenanz
approved these changes
Feb 17, 2026
hjmjohnson
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced function calls of the form
iterator.GetIndex()withiterator.ComputeIndex(), for iterators derived fromImageConstIterator, in "Modules/Nonunit/Review"Fixes compile errors that occur when compiling with
Module_ITKReview=ONandITK_FUTURE_LEGACY_REMOVE=ON, like:As occurred at RogueResearch24/Mac13.x-AppleClang-dbg-Universal: https://open.cdash.org/viewBuildError.php?buildid=11052824
Reported by Bradley Lowekamp (@blowekamp) at
#5803 (comment)