Skip to content

Fix prefetch-dataset hang on GPU #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ethanglaser wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix prefetch-dataset hang on GPU #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23d2f23
Fix prefetch-dataset hang on GPU
ethanglaser Apr 7, 2026
6c88e85
try with threadpoole executor
ethanglaser Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sklbench/runner/implementation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import argparse
import json
from multiprocessing import Pool
from concurrent.futures import ThreadPoolExecutor
from typing import Dict, List, Tuple, Union

from psutil import cpu_count
Expand Down Expand Up @@ -102,8 +102,8 @@ def run_benchmarks(args: argparse.Namespace) -> int:
logger.debug(f"Unique dataset names to load:\n{list(dataset_cases.keys())}")
n_proc = min([16, cpu_count(), n_datasets])
logger.info(f"Prefetching {n_datasets} datasets with {n_proc} processes")
with Pool(n_proc) as pool:
pool.map(load_data_with_cleanup, dataset_cases.values())
with ThreadPoolExecutor(max_workers=n_proc) as executor:
list(executor.map(load_data_with_cleanup, dataset_cases.values()))

# run bench_cases
return_code, result = call_benchmarks(
Expand Down
Loading