Merged
Conversation
79ff0e5 to
4803708
Compare
There was a problem hiding this comment.
Pull request overview
This PR represents a major refactoring to achieve v1.5 parity with the C++ SDK, bumping the version from 0.1.0-alpha.6 to 0.1.0-alpha.7. The changes include significant restructuring of both the Rust SDK and Python bindings, adding comprehensive support for multiple robot control subsystems including AI, vision, camera control, and LED lighting.
Changes:
- Reorganized client modules into separate domain-specific clients (BoosterClient, AiClient, LuiClient, VisionClient, X5CameraClient, LightControlClient)
- Introduced
api_id_enum!macro for consistent API ID enum generation with serde support - Added extensive new types for B1 robot control including locomotion, kinematics, and high-level API types
- Restructured Python bindings to match the new modular architecture with proper type stubs
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pixi.toml | Version bump to 0.1.0-alpha.7 |
| Cargo.toml | Workspace version update |
| booster_sdk/src/types/b1.rs | New comprehensive type definitions for B1 robot APIs |
| booster_sdk/src/types/robot.rs | Refactored RobotMode and GripperMode to use api_id_enum macro |
| booster_sdk/src/types/error.rs | Added Conflict and RequestTooFrequent error variants |
| booster_sdk/src/dds/topics.rs | Changed TopicSpec.name to String, added service topic constants |
| booster_sdk/src/dds/rpc.rs | Added multi-service RPC client support with topic normalization |
| booster_sdk/src/dds/messages.rs | Updated LightControlMsg structure |
| booster_sdk/src/client/mod.rs | Added api_id_enum macro and new client module exports |
| booster_sdk/src/client/loco.rs | Moved and expanded BoosterClient with full locomotion API |
| booster_sdk/src/client/ai.rs | New AI and LUI client implementations |
| booster_sdk/src/client/vision.rs | New vision service client |
| booster_sdk/src/client/x5_camera.rs | New X5 camera control client |
| booster_sdk/src/client/light_control.rs | New LED light control client |
| booster_sdk_py/src/lib.rs | Refactored to delegate to modular client modules |
| booster_sdk_py/src/client/*.rs | New Python binding modules mirroring Rust structure |
| booster_sdk_py/booster_sdk_bindings/*.pyi | Comprehensive type stub updates |
| booster_sdk_py/booster_sdk/*.py | Restructured Python package with modular client imports |
| .github/workflows/release.yml | Added publish-crate job for crates.io publishing |
| README.md | Updated documentation reflecting new capabilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.