Skip to content

Bs21 gha version updates#330

Merged
stumbo merged 14 commits intomainfrom
bs21_GHA_version_updates
Apr 14, 2026
Merged

Bs21 gha version updates#330
stumbo merged 14 commits intomainfrom
bs21_GHA_version_updates

Conversation

@stumbo
Copy link
Copy Markdown
Member

@stumbo stumbo commented Mar 13, 2026

On June 2, 2026 GitHub will be moving to Node.js 24. This PR updates several of the actions we use to versions that support Node.js 24. In addition, I replaced one action, fjogeleit/http-request-action with a basic curl command. The action was using a deprecated function and maintenance on the action appeared to be minimal. This removes the reliance on node.js and preserves the needed functionality.

I also made a couple minor enhancements and potential bug fixes based on Copilot's recommendations.

There currently is an environment variable, FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 that needs to be removed prior to merging. This forces it to run with Node.js 24. I have the action currently deployed on my staging site. It all appears to be working correctly. I'll leave it running there to make sure I didn't miss anything.

There are two actions that will need to be updated once new versions are released:
- actions/configure-pages
- actions/upload-artifact
As of April 11, 2026 both of these actions have been updated and are now Node.js 24 compliant.

While they appear to run correctly on Node.js 24 I would prefer to have actions that are built with this version.

stumbo added 4 commits March 12, 2026 23:56
Updates to actions to ensure they support node.js 24.  GHA will
default to this version of node.js in June 2026.

This update will fix the following warning message:

```
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, fjogeleit/http-request-action@v1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
```
http-request-action uses url.parse() which is being deprecated.
Instead of waiting and hoping it is updated this replaces it
and removes a dependency on node.js.
Fixes a couple minor issues:
 - TZ specified incorrectly
 - Add concurrency group to prevent parallel deployments
 - Cleaned up npm install and adding caching
 - Fix incorrect ID reference
 - Switch from v5.0.3 to v5 for cache actions to automatically get
   security updates.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Pages deployment workflow to prepare for GitHub Actions’ move to Node.js 24 by bumping action versions, removing a deprecated third-party Node-based HTTP action, and improving workflow behavior (e.g., concurrency).

Changes:

  • Replace fjogeleit/http-request-action with a curl-based header probe to derive the Zotero cache key.
  • Update multiple first-party actions (cache, checkout, setup-node, upload-pages-artifact) and switch Node to v24 with npm caching.
  • Add workflow-level concurrency and adjust minor build/install details (e.g., TZ format, consolidated npm installs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/gh-pages.yml Outdated
Comment thread .github/workflows/gh-pages.yml Outdated
Comment thread .github/workflows/gh-pages.yml Outdated
pamoroso and others added 3 commits March 13, 2026 14:23
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paolo Amoroso <paolo.amoroso@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paolo Amoroso <paolo.amoroso@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paolo Amoroso <paolo.amoroso@gmail.com>
Copy link
Copy Markdown
Member

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The staging site looks fine.

stumbo added 3 commits March 13, 2026 22:03
I want to keep this flag in the file until I'm ready to merge into main.
As I make updates and validate them on my staging site I want to be sure
the changes work on node.js 24.
Adds suppport for Node.js 24
Support for node.js 24
@stumbo stumbo force-pushed the bs21_GHA_version_updates branch from 50802a1 to 9ee7bd8 Compare March 27, 2026 11:32
stumbo added 2 commits April 10, 2026 23:55
All actions are updated and workflow is now compliant with NodeJS 24.
@stumbo stumbo marked this pull request as ready for review April 11, 2026 04:16
@stumbo stumbo requested a review from Copilot April 11, 2026 04:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Pages deployment workflow to use newer GitHub Actions versions compatible with the upcoming Node.js 24 runtime, and replaces an HTTP-request action with a direct curl call to reduce reliance on a minimally maintained JavaScript action.

Changes:

  • Added workflow-level concurrency to cancel in-progress pages runs per ref.
  • Replaced fjogeleit/http-request-action with a curl-based header parse to obtain the Zotero Last-Modified-Version.
  • Bumped multiple GitHub Actions versions and updated Node setup/install steps for Node 24 (including switching to npm ci and enabling npm caching).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/gh-pages.yml Outdated
Comment thread .github/workflows/gh-pages.yml Outdated
stumbo added 2 commits April 13, 2026 08:07
Thought this change was made with the last commit, but evidently not.
@stumbo stumbo merged commit 1cf2776 into main Apr 14, 2026
4 checks passed
@stumbo stumbo deleted the bs21_GHA_version_updates branch April 14, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants