Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MoE expert-dispatch distribution recorder to the PyTorch backend, enabling periodic dumps of routed expert counts to JSON for debugging/analysis (intended for eager-mode runs).
Changes:
- Introduce
ExpertsDistributionRecorderutility (real vs no-op based on env flags) that aggregates and dumps expert token counts. - Hook the recorder into Qwen3 MoE and DeepSeek V2 MoE forward passes to record
topk_ids. - Add new environment variables for enabling/disabling and configuring dump output.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
lmdeploy/pytorch/models/utils/expert_distribution_recorder.py |
New recorder implementation that tracks expert token counts and periodically dumps JSON. |
lmdeploy/pytorch/models/qwen3_moe.py |
Records MoE router topk_ids per forward for Qwen3 MoE blocks. |
lmdeploy/pytorch/models/deepseek_v2.py |
Records MoE router topk_ids per forward for DeepSeek V2 MoE blocks; stores layer_idx. |
lmdeploy/pytorch/envs.py |
Adds env configuration knobs for expert distribution dumping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Sort by (layer_index, num_experts) for stable JSON output - Use topk_ids.device instead of hard-coded 'cuda' - Use reshape(-1) instead of view(-1) for non-contiguous safety - Move all_reduce inside dump block to avoid per-step sync overhead - Replace minute-modulo dump guard with absolute timestamp; validate dump_frequency >= 1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from dlBLAS.
Usage
Result