Skip to content

gRPC: GHC 9.12 support#1098

Merged
carbolymer merged 2 commits intomasterfrom
mgalazyn/proto-lens-ghc-9.12
Feb 18, 2026
Merged

gRPC: GHC 9.12 support#1098
carbolymer merged 2 commits intomasterfrom
mgalazyn/proto-lens-ghc-9.12

Conversation

@carbolymer
Copy link
Copy Markdown
Contributor

@carbolymer carbolymer commented Jan 30, 2026

Changelog

- description: |
    Add GHC 9.12 support for cardano-rpc
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-api
  # - cardano-api-gen
   - cardano-rpc
  # - cardano-wasm

Context

This PR reenables cardano-rpc and adds GHC 9.12 support. This requires a proto-lens SRP with changes not merged yet.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Jan 30, 2026
@carbolymer carbolymer linked an issue Jan 30, 2026 that may be closed by this pull request
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch 2 times, most recently from 947e95b to 05a9977 Compare January 30, 2026 13:54
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch 3 times, most recently from 5b74736 to ece078e Compare February 6, 2026 17:17
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from a6322a8 to 336eb8f Compare February 11, 2026 09:11
@carbolymer carbolymer changed the title gRPC: GHC 9.12 support WIP: gRPC: GHC 9.12 support Feb 11, 2026
@carbolymer carbolymer marked this pull request as ready for review February 11, 2026 09:11
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch 8 times, most recently from bdd41c3 to 36a4c84 Compare February 13, 2026 21:28
@carbolymer carbolymer changed the base branch from master to mgalazyn/update-ci-conf February 16, 2026 12:07
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from 36a4c84 to f8fe069 Compare February 16, 2026 12:08
@carbolymer carbolymer force-pushed the mgalazyn/update-ci-conf branch from 96de352 to 3bd029c Compare February 16, 2026 12:12
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch 4 times, most recently from a879132 to 3484016 Compare February 16, 2026 13:05
@carbolymer carbolymer changed the title WIP: gRPC: GHC 9.12 support gRPC: GHC 9.12 support Feb 16, 2026
@palas palas force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from 8a3545c to 3484016 Compare February 16, 2026 20:18
Copy link
Copy Markdown
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good and CI passes. Just a couple of minor comments

Comment thread cardano-rpc/src/Cardano/Rpc/Server/Internal/Orphans.hs Outdated
Comment thread flake.nix Outdated
@carbolymer carbolymer force-pushed the mgalazyn/update-ci-conf branch from 3bd029c to a54fff5 Compare February 17, 2026 10:38
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from 8cb4037 to edfb3f9 Compare February 17, 2026 11:07
Base automatically changed from mgalazyn/update-ci-conf to master February 17, 2026 11:34
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from edfb3f9 to 25346b0 Compare February 17, 2026 18:35
@carbolymer carbolymer force-pushed the mgalazyn/proto-lens-ghc-9.12 branch from 25346b0 to 936deb7 Compare February 17, 2026 18:36
@carbolymer carbolymer added this pull request to the merge queue Feb 18, 2026
Merged via the queue into master with commit 63f5c1d Feb 18, 2026
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/proto-lens-ghc-9.12 branch February 18, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC: Build cardano-rpc with GHC 9.12

2 participants