Add TreeDiff utilities to cardano-binary testlib#638
Open
MavenRain wants to merge 1 commit intoIntersectMBO:masterfrom
Open
Add TreeDiff utilities to cardano-binary testlib#638MavenRain wants to merge 1 commit intoIntersectMBO:masterfrom
MavenRain wants to merge 1 commit intoIntersectMBO:masterfrom
Conversation
(cardano-ledger#5360)
Collaborator
|
Did you mean IntersectMBO/cardano-ledger#5360? |
Author
|
Yes I did. My apologies. I'll correct the description. |
lehins
reviewed
Apr 16, 2026
| srcLocToLocation, | ||
| ) where | ||
|
|
||
| import qualified Cardano.Binary as Plain |
Collaborator
There was a problem hiding this comment.
There is no versioned decoder in cardano-base, so it makes sense to remove sense to remove qualified import as Plain
Suggested change
| import qualified Cardano.Binary as Plain | |
| import Cardano.Binary |
Comment on lines
+33
to
+49
| -- * Re-exports from tree-diff | ||
| Expr (App, Rec, Lst), | ||
| defaultExprViaShow, | ||
| ediff, | ||
| ppEditExpr, | ||
|
|
||
| -- * Re-exports from prettyprinter | ||
| Pretty (..), | ||
| Doc, | ||
| AnsiStyle, | ||
| ansiWlPretty, | ||
|
|
||
| -- * Re-exports from ImpSpec | ||
| ansiDocToString, | ||
| assertColorFailure, | ||
| callStackToLocation, | ||
| srcLocToLocation, |
Collaborator
There was a problem hiding this comment.
We should not be re-exporting stuff from other libraries.
Suggested change
| -- * Re-exports from tree-diff | |
| Expr (App, Rec, Lst), | |
| defaultExprViaShow, | |
| ediff, | |
| ppEditExpr, | |
| -- * Re-exports from prettyprinter | |
| Pretty (..), | |
| Doc, | |
| AnsiStyle, | |
| ansiWlPretty, | |
| -- * Re-exports from ImpSpec | |
| ansiDocToString, | |
| assertColorFailure, | |
| callStackToLocation, | |
| srcLocToLocation, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #5360 (Part 1)